[email protected] #6510
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (nextpnr, prjtrellis) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new modules, [email protected] and its dependency [email protected]. The overall structure is good and follows the BCR guidelines. However, I've found a few critical configuration errors that need to be addressed:
- The module name for
nextpnris misspelled asnexpnrin itsMODULE.bazelfiles. - The
source.jsonfor theprjtrellismodule incorrectly points to thenextpnrsource archive.
Please see the detailed comments for suggestions on how to fix these issues.
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
|
@fmeum can I get a presubmit stamp? |
fmeum
added
the
presubmit-auto-run
| http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( | ||
| name = "prjtrellis_db", |
There was a problem hiding this comment.
Should this be a module or is it okay if this is duplicated across multiple deps?
There was a problem hiding this comment.
Converted this to a module!
Head branch was pushed to by a user without write access
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (nextpnr, prjtrellis-db, prjtrellis) have been updated in this PR. |
|
@fmeum friendly ping here. |
3 participants
closes #6065